Discussion:
Typo in cl-compile.el
Marco Gidde
2004-06-10 21:58:57 UTC
Permalink
The second CAR should probably be a CDR.


===================================================================
RCS file: /usr/local/cvsroot/emacs-cl/cl-compile.el,v
retrieving revision 1.84
diff -u -3 -p -a -F^(def -r1.84 cl-compile.el
--- cl-compile.el 9 Jun 2004 21:51:28 -0000 1.84
+++ cl-compile.el 10 Jun 2004 21:51:46 -0000
@@ -346,7 +346,7 @@ (defun built-in-make-load-form (form &op
;; TODO: RANDOM-STATE
((consp form)
(if (and (ok-for-file-literal-p (car form))
- (ok-for-file-literal-p (car form)))
+ (ok-for-file-literal-p (cdr form)))
(cl:values `(cons ,(car form) ,(cdr form)))
(cl:values
`(cons nil nil)
--
Marco Gidde
Lars Brinkhoff
2004-06-11 08:07:04 UTC
Permalink
Post by Marco Gidde
- (ok-for-file-literal-p (car form)))
+ (ok-for-file-literal-p (cdr form)))
The second CAR should probably be a CDR.
Of course! Thanks.
--
Lars Brinkhoff, Services for Unix, Linux, GCC, HTTP
Brinkhoff Consulting http://www.brinkhoff.se/
Lars Brinkhoff
2004-06-11 08:15:32 UTC
Permalink
Hints for people sending patches:

* If your change is a bug fix, add a test case to tests.lisp.
(The test should fail without the patch and succeed after patch
application.)

* Run "make check" to verify that no (new) bugs are introduced by
your change.

* Use "diff -uF'^def' ..." or equivalent to make the patch.

* Include the patch verbatim in the mail body. No attachments.
--
Lars Brinkhoff, Services for Unix, Linux, GCC, HTTP
Brinkhoff Consulting http://www.brinkhoff.se/
Loading...